Skip to content

Note major versions are not automatically tagged #17776

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Aug 23, 2022
Merged

Note major versions are not automatically tagged #17776

merged 7 commits into from
Aug 23, 2022

Conversation

@Kurt-von-Laven
Copy link
Contributor

@Kurt-von-Laven Kurt-von-Laven commented May 11, 2022 •
edited
Loading

The previous wording can be misinterpreted to suggest that GitHub Actions itself automatically tags major versions. Also, remove assurance that pinning the major version protects your workflow from breaking. This is only true if the action you depends on never introduces any bugs that affect you. In other words, it's false in practice.

Why:

Closes #17071.

What's being changed:

See rich diff.

Check off the following:

  • I have reviewed my changes in staging (look for "Automatically generated comment" and click Modified to view your latest changes).
  • For content changes, I have completed the self-review checklist.

Writer impact (This section is for GitHub staff members only):

  • This pull request impacts the contribution experience
    • I have added the 'writer impact' label
    • I have added a description and/or a video demo of the changes below (e.g. a "before and after video")

@Kurt-von-Laven
Note major versions are not automatically tagged
7d66b76 
The previous wording can be misinterpreted to suggest that GitHub
Actions itself automatically tags major versions.

Also, remove assurance that pinning the major version protects your
workflow from breaking. This is only true if the action you depends on
never introduces any bugs that affect you. In other words, it's false in
practice.
@github-actions github-actions bot added the triage Do not begin working on this issue until triaged by the team label May 11, 2022
@github-actions
Copy link
Contributor

github-actions bot commented May 11, 2022 •
edited
Loading

Automatically generated comment ℹ️

This comment is automatically generated and will be overwritten every time changes are committed to this branch.

The table contains an overview of files in the content directory that have been changed in this pull request. It's provided to make it easy to review your changes on the staging site. Please note that changes to the data directory will not show up in this table.

Content directory changes

You may find it useful to copy this table into the pull request summary. There you can edit it to share links to important articles or changes and to give a high-level overview of how the changes in your pull request support the overall goals of the pull request.

Source Preview Production What Changed
actions/using-workflows/workflow-syntax-for-github-actions.md fpt
ghec
ghes@ 3.6 3.5 3.4 3.3 3.2
ghae
 fpt
ghec
ghes@ 3.6 3.5 3.4 3.3 3.2
ghae

fpt: Free, Pro, Team
ghec: GitHub Enterprise Cloud
ghes: GitHub Enterprise Server
ghae: GitHub AE

@Kurt-von-Laven

This comment was marked as outdated.

Sign in to view
@ramyaparimi ramyaparimi added content This issue or pull request belongs to the Docs Content team actions This issue or pull request should be reviewed by the docs actions team waiting for review Issue/PR is waiting for a writer's review needs SME This proposal needs review from a subject matter expert and removed triage Do not begin working on this issue until triaged by the team labels May 12, 2022
@github-actions
Copy link
Contributor

github-actions bot commented May 12, 2022

Thanks for opening a pull request! We've triaged this issue for technical review by a subject matter expert 👀

@github-actions
Copy link
Contributor

github-actions bot commented May 19, 2022

This is a gentle bump for the docs team that this PR is waiting for technical review.

@github-actions github-actions bot added the SME stale The request for an SME has staled label May 19, 2022
@janiceilene janiceilene removed the needs SME This proposal needs review from a subject matter expert label May 24, 2022
jsoref
jsoref reviewed Jul 6, 2022
View reviewed changes
@janiceilene janiceilene added needs SME This proposal needs review from a subject matter expert and removed SME stale The request for an SME has staled labels Jul 19, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Jul 19, 2022

Thanks for opening a pull request! We've triaged this issue for technical review by a subject matter expert 👀

Martin Lopes and others added 2 commits July 21, 2022 15:41
@jsoref
Apply suggestions from code review
7194d4a 
Co-authored-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
@jsoref
Apply suggestions from code review
a61d927 
Co-authored-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
@martin389
Copy link
Contributor

martin389 commented Jul 21, 2022

Thanks for this PR! 👍 I've added some small edits to prepare it for review from an engineering team

@github-actions
Copy link
Contributor

github-actions bot commented Jul 29, 2022

This is a gentle bump for the docs team that this PR is waiting for technical review.

@github-actions github-actions bot added the SME stale The request for an SME has staled label Jul 29, 2022
@cmwilson21 cmwilson21 removed the SME stale The request for an SME has staled label Aug 1, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Aug 8, 2022

This is a gentle bump for the docs team that this PR is waiting for technical review.

@github-actions github-actions bot added the SME stale The request for an SME has staled label Aug 8, 2022
@cmwilson21 cmwilson21 removed the SME stale The request for an SME has staled label Aug 9, 2022
@martin389 martin389 merged commit 34ef33b into github:main Aug 23, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Aug 23, 2022

Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. If you're looking for your next contribution, check out our help wanted issues ⚡

@Kurt-von-Laven Kurt-von-Laven deleted the major-versions-not-automatically-tagged branch August 23, 2022 09:41
@Kurt-von-Laven Kurt-von-Laven mentioned this pull request Aug 27, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

3 more reviewers

@jsoref jsoref jsoref left review comments

@ElDisciplina ElDisciplina ElDisciplina left review comments

@martin389 martin389 martin389 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

actions This issue or pull request should be reviewed by the docs actions team content This issue or pull request belongs to the Docs Content team needs SME This proposal needs review from a subject matter expert waiting for review Issue/PR is waiting for a writer's review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Clarify That GitHub Actions Don't Automatically Understand Semantic Versioning

7 participants

@Kurt-von-Laven @martin389 @jsoref @ElDisciplina @janiceilene @ramyaparimi @cmwilson21